StackedNotificationsBehavior port #170
Conversation
michael-hawker
added
documentation
…w notification in sample
…Toolkit control Adds additional `Show` methods to act as backward compatibile helpers.
…ve constant values for Notifications Added test for override scenario
…r Closing event Added a Clear method to clear all notifications on the StackedNotificationsBehavior Added more migration notes
michael-hawker
force-pushed
the
llama/infobar-notifications
branch
from
600769f
to
46b8b43
Compare
|
Force pushed, forgot to adjust author of initial port commit, did an interactive rebase and:
|
…unityToolkit/Windows into llama/infobar-notifications
|
@michael-hawker updated the icon, made a minor tweak to the samples so they don't "jump" whenever a notification is shown using a |
|
Seeing the tests failing with our unknown platform issue again, updating our build script with the diagnostic log flags to get more info (also updating some versions and other things needed by the CI that had diverted from Labs, like the Page file and non-.NET Native release). |
…ckedNotificationsBehavior
|
With the extra diagnostics I did see there was an issue in the StackedNotificationsBehavior test due to the timer firing after the test had removed the UI element, so I fixed that by adding the |
|
Added some extra build diagnostics to analyze crashes a bit in the pipeline itself (if they occur). Also trying to ignore the called out test and see what happens. 🤞 @Arlodotexe any concerns with the build modifications, think we can leave the diagnostics on all the time for now to help us, as the large dump only gets uploaded if there was a dump, so any good builds won't add much extra noise or size anyway? |
This migrates, updates, and amends the
StackedNotificationsBehaviorfrom Labs by @vgromfeldThis PR provides:
BehaviorscomponentClearmethod to remove all NotificationsIconSourcetoNotificationto allow for custom icons per notificationSeverityandTitle, thus allowing parent properties on anInfoBarto be set and used by all notifications more easilyMigration Notes from InAppNotification:
StackModeto change behavior of queuing messages, was thinking of adding, but then realized it was a more disruptive user experience in general to replace an active notification. Added a note, thoughts @niels9001?Opened/Openingevent for the notification. Theoretically you should be able to just register to theIsOpenproperty changed notification... see related platform issue withInfoBaritself: Proposal: Add 'Opened' event to InfoBar microsoft/microsoft-ui-xaml#3761Needs: